-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daybreak rework #24
base: master
Are you sure you want to change the base?
Daybreak rework #24
Conversation
… file and #auto_saved_files# (hopefully this does not break anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today I learned that KiCAD doesn't differentiate between net labels and hierarchical labels if they're named the same thing. Pressing ~ on the net shows that KiCAD thinks they are electrically connected:
consider renaming the name of the nets to be different.
Some ERC stuff:
- the "Foward" pin on the MCU isn't connected to anything (misspelling go brrrr)
- power labels are global so you don't need to have hierarchical labels. Either way, the relevant hierarchical labels aren't on the sheet.
The dashboard PCB has pin 2 of the dashboard connector as BPS hazard and y'all have it as regen.
I thought we were getting rid of the 555 timer in favor of doing it in software? Doing it in hardware is also fine, was just wondering.
Make sure you update all the footprints and ask for a review on that before you start layout.
You shouldn't need to use the "SI8261ABC-IS" gate drivers, you should be able to just use the EL3H7 (right @ppatra126 ?) The gate of the mosfet doesn't sink that much current.
Right_Ind and Left_Ind are at 12V logic and referenced to GNDPWR, so you can't plug it into the gate of your mosfet since the 5V of the timer is referenced to GND (thus breaking the isolation barrier).
…e MinionBrdInterface so that they aren't connected. Changed Regen input to BPS Hazard light since we aren't using regen but will be alerting the driver of BPS faults.
…r to motor can and disconnected shield pins for now since I haven't seen them used (will chack against old version to see what the circuit looked like), copied power-in circuit from contactor board, added optoisolator to timer and blinker light connection.
…pefully this did not involve doing anything that wasn't supposed to be done.
Thank you both for the reviews! Lakshay: We decided we like abstracting the blinky stuff into hardware, so we plan to keep the timer unless @diyarajon prefers software. Prat: Additional changes/concerns:
Thank you very much! |
|
I would definitely add a P/N (part number) and footprint to every component on here. Looks like the footprints are OK but double check that they're the ones you want. |
Also can you make that one 45 degree cap not 45 degrees, it's weird that it's the only thing that's 45 |
…paths, reconnected item (my bad, sorry about that).
Can you fix wtv setting is giving you all those bridging nets violation? Can you move Array_PBC_Sense up a little bit so there's a clean fill in the MCU gnd fill |
Other than that lgtm |
I got rid of the errors by allowing bridged solder mask apertures between pads, so the footprints no longer match the library, but KiCAD doesn't complain anymore. I wasn't sure where Array_PBC_Sense was causing issues, so I just looked over the fills and tried to see if there were any areas I could improve. I'll work on the BOM and other images next. Thanks so much for all your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…chematic and layout updated.
Quality Assurance Checklist
To make reviews more efficient, please make sure the board meets the following standards and check everything off once the board meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.
There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.
Please read every word on every bullet point before checking off the corresponding box.
Minimum Prerequisites
Please read every word on every bullet point before checking off the corresponding box.
Schematic Level Requirements
Please read every word on every bullet point before checking off the corresponding box.
BOM Requirements
Please read every word on every bullet point before checking off the corresponding box.
Layout Level Requirements
2D Spacing
3D Spacing
Components
Copper Layer
*Not really a problem for modern manufacturing techniques but good practice and important for high speed signal integrity.
Silkscreen Layer
Edge Cut Layer
Please read every word on every bullet point before checking off the corresponding box.
IMPORTANT NOTICE
Other Comments
Write any comments about the board that would help the reviewers here.